Consents for training requests #2363
Conversation
It contains common fields and methods used in descendant classes. New descendant to be introduced in next commit.
…ing consent fields This solution is similar to the approach from BaseTermConsentsForm.
pbanaszkiewicz
force-pushed
the
feature/2162-request-training-consents
branch
from
7a97b14
to
11e94f8
Compare
|
Ready for your review, @elichad! |
| @@ -963,6 +952,18 @@ def trainingrequests_merge(request): | |||
| "obj_a": obj_a, | |||
| "obj_b": obj_b, | |||
| "form": form, | |||
| "obj_a_consents": { | |||
| return False | ||
| # Create new style consents based on the training request consents used in the | ||
| # training request form. | ||
| training_request_consents = TrainingRequestConsent.objects.filter( |
There was a problem hiding this comment.
After this change/migration, we will have some training requests in the database which don't have any TrainingRequestConsents set. Am I right in understanding that if a Person is created from such a request, they will instead provide these consents when they first log in to AMY?
There was a problem hiding this comment.
Side comment - I haven't actually been able to test the creation of a Person from a training request with this PR. Locally I get an error:
BadCredentialsException at /requests/training_request/41/
401 {"message": "Bad credentials", "documentation_url": "https://docs.github.com/rest"}
I assume this is because I don't have GH auth in my local instance. And I assume it won't work on test-amy for the same reason? Is there some way we can double check this works in the UI before releasing it?
There was a problem hiding this comment.
After this change/migration, we will have some training requests in the database which don't have any TrainingRequestConsents set. Am I right in understanding that if a Person is created from such a request, they will instead provide these consents when they first log in to AMY?
I have just tested this and you are correct.
Locally I get an error:
Yes, this is because it's trying to confirm GH handle with GH API. You can erase the handle from request by editing it and you should be able to continue.
You can also create a token for your own use here: https://github.com/settings/tokens
Use AMY_GITHUB_API_TOKEN envvar to set the token.
| @@ -141,13 +141,25 @@ | |||
| — | |||
| {% endif %} | |||
| </td></tr> | |||
| <tr><th>Data privacy agreement:</th> | |||
| <tr><th><span class="badge badge-secondary">(Deprecated)</span> Data privacy agreement:</th> | |||
There was a problem hiding this comment.
At what point would we remove this line altogether (if ever)?
There was a problem hiding this comment.
I don't know. Perhaps we should keep this for now.
This fixes #2162.
To-do:
TrainingRequestConsentwhen training request is createdTrainingRequestConsents asConsents when matching training request with a person